Conversation
Concat multiple operators with 'and'
dknogl
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR simplifies the
CASEternary operator implementation in query filter expressions by moving it from a per-property level to theQueryFilterlevel.Motivation
The previous implementation (introduced in #54) embedded the
CASEoperator deeply into individual filter property types (CaseNode,CaseExpression,InCaseNode) and theTHEN/ELSEbranches resolved to raw values (strings, numbers, booleans) or nestedCaseNodes. That added significant type complexity and lead to less flexibility.This PR takes a simpler approach:
CASEis now a top-level clause inQueryFilter<T>(alongsideAND,OR, andNOT), whereIF,THEN, andELSEare allQueryFilter<T>expressions. This makes the feature more composable and consistent with existing logical operators.Remarks
For reviewing this PR it makes sense to compare it to PR #53 (commit 65ad1ef) since the changes of PR #54 (commit 30d8393) were almost completely reverted.